feat: more friendly cli error message #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Feb 28, 2023
| @@ -119,3 +119,18 @@ func handleExitCoder(err error) { | |||
| return | |||
| } | |||
| } | |||
|
|
|||
| func WrapArgsError(argFn cobra.PositionalArgs) cobra.PositionalArgs { | |||
There was a problem hiding this comment.
Please consider adding a comment line
There was a problem hiding this comment.
Thanks for quick review, updated in 48ae695.
Signed-off-by: pengyu <pengyu@pingcap.com>
lobshunter
force-pushed
the
args-error
branch
from
e8a8f4c
to
48ae695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1211, show more user friendly error message on argument error. The output is similar to nerdctl and docker cli.
It looks like below:
