Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: gvisor.dev/gvisor v0.0.0-20231023213702-2691a8f9b1cf (Support Go 1.22) #2137

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jan 15, 2024

This revision is compatible with Go 1.20, 1.21, and 1.22rc1. New versions (>= v0.0.0-20231024051821-3b00acd67af2) are no longer compatible with Go 1.20.

Fixes #2133

This revision is compatible with Go 1.20, 1.21, and 1.22rc1.
New versions (>= v0.0.0-20231024051821-3b00acd67af2) are no longer
compatible with Go 1.20.

Fixes issue 2133

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the v0.20.0 milestone Jan 15, 2024
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 15, 2024
@jandubois
Copy link
Member

This revision is compatible with Go 1.20, 1.21, and 1.22rc1.

I know there is nothing we can do about this, but this narrow coupling between package versions and Go releases makes it quite painful to run git bisect over a range of Lima releases, as different commits will need to be compiled with different Go versions.

I hope at some point they will become compatible with all upcoming Go releases; the Go team spends a lot of effort on keeping Go backwards compatible...

@AkihiroSuda
Copy link
Member Author

This revision is compatible with Go 1.20, 1.21, and 1.22rc1.

I know there is nothing we can do about this, but this narrow coupling between package versions and Go releases makes it quite painful to run git bisect over a range of Lima releases, as different commits will need to be compiled with different Go versions.

I hope at some point they will become compatible with all upcoming Go releases; the Go team spends a lot of effort on keeping Go backwards compatible...

Yes, maybe we can consider using another TCP/IP implementation if they aren't interested in supporting multiple Go versions

@AkihiroSuda
Copy link
Member Author

Can we merge this?

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jandubois jandubois merged commit ed64de4 into lima-vm:master Jan 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Go 1.22
2 participants