Move containerd archives from code to yaml #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
force-pushed
the
containerd-yaml
branch
from
31d0070
to
be28b75
Compare
|
For instance, for newer versions of podman: |
|
Possibly the version should be removed from the yaml, and be made a part of the filename instead ?
Similar to the change made for the "image.yaml". The |
alexandear
reviewed
Jun 17, 2024
afbjorklund
force-pushed
the
containerd-yaml
branch
2 times, most recently
from
8590963
to
48db7d1
Compare
alexandear
approved these changes
Jun 17, 2024
|
CI is failing, could you try rebasing? |
afbjorklund
force-pushed
the
containerd-yaml
branch
from
48db7d1
to
772e420
Compare
AkihiroSuda
previously approved these changes
Jul 17, 2024
|
Sorry, needs rebase again |
This makes it more similar to update compared to the images, and allows for integrating with other archives in the future. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
force-pushed
the
containerd-yaml
branch
from
772e420
to
bb4c757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more similar to update compared to the images, and allows for integrating with other archives in the future*.