Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selinux label for rosetta from nfs_t to bin_t #2630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hasan4791
Copy link
Contributor

With recent integration with systemd-binfmt,the existing nfs_t selinux label for Rosetta is causing issues while registering it. This behaviour needs to be fixed by setting the label as bin_t.

Fixes: #2627

hack/test-selinux.sh Outdated Show resolved Hide resolved
@hasan4791
Copy link
Contributor Author

hasan4791 commented Sep 19, 2024

Wondering whats causing the test failure!!!
Locally this works but not in CI

As per this line, the file has been updated
https://github.com/lima-vm/lima/actions/runs/10935435606/job/30357191260?pr=2630#step:9:593

Edit: Resolved.

With recent integration with systemd-binfmt,the existing nfs_t
selinux label for Rosetta is causing issues while registering it.
This behaviour needs to be fixed by setting the label as bin_t

Signed-off-by: T K Chandra Hasan <t.k.chandra.hasan@ibm.com>
@hasan4791
Copy link
Contributor Author

@AkihiroSuda couls you help me with rerunning those failed/cancelled tests again. Looks to be flaky!!

@hasan4791
Copy link
Contributor Author

Required test jobs are passed now but some job is failing which is irrelevant to the changes in this PR.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Sep 20, 2024
@AkihiroSuda AkihiroSuda requested a review from a team September 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rosetta register failing in Fedora distro - Selinux denial
2 participants