Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Import selection and editing code from Masonry #88

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Jul 22, 2024

This is a little earlier than planned as masonry's dependency on vello was making this awkward to use from masonry (when I am not necessary depending on the same version of vello).

Changes made

  • Add dependencies on xi-unicode, unicode_segmentation, dpi, and winit
  • Import text2 module from masonry
  • Import type ArcStr = Arc<str> from masonry
  • Import event types from masonry
  • Remove vello dependency (drawing is left up to the user)
  • Fix imports of other dependencies
  • Updated to work with latest parley API

Todo

  • Feature flag editing feature
  • Move selection out of editor module?
  • Simplify event types
  • Add a new (non-masonry) way to be notified when text changes in response to an event

@nicoburns nicoburns marked this pull request as draft July 22, 2024 01:39
@nicoburns nicoburns added the enhancement New feature or request label Jul 22, 2024
@DJMcNab DJMcNab self-requested a review July 22, 2024 10:41
@nicoburns nicoburns force-pushed the editor branch 4 times, most recently from 395caae to 0492eb3 Compare July 22, 2024 23:03
@nicoburns
Copy link
Contributor Author

I've rebased this on main to simplify the diff now that #76 has been merged. I am no longer anticipating this being merged in it's current state, but I'd like to leave it open for now as it contains useful changes that remove dependencies that I think we will want to port to Masonry's version of this code (CC: @PoignardAzur)

This Zulip thread contains my new proposal for making the changes contained in this PR: https://xi.zulipchat.com/#narrow/stream/205635-text/topic/Sharing.20selection.2Fediting.20code.20between.20Blitz.20and.20Masonry

@DJMcNab DJMcNab removed their request for review September 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant