Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icu_locid, icu_properties #91

Merged

Conversation

waywardmonkeys
Copy link
Contributor

This update brings us to zerovec 0.10.4 which addresses a flaw that Dependabot is warning about:

The affected versions make unsafe memory accesses under the
assumption that #[repr(packed)] has a guaranteed field order.

The Rust specification does not guarantee this, and
rust-lang/rust#125360 (1.80.0-beta) starts reordering
fields of #[repr(packed)] structs, leading to illegal memory
accesses.

The patched versions 0.9.7 and 0.10.3 use #[repr(C, packed)],
which guarantees field order.

This update brings us to zerovec 0.10.4 which addresses a flaw
that Dependabot is warning about:

> The affected versions make unsafe memory accesses under the
> assumption that `#[repr(packed)]` has a guaranteed field order.
>
> The Rust specification does not guarantee this, and
> rust-lang/rust#125360 (1.80.0-beta) starts reordering
> fields of `#[repr(packed)]` structs, leading to illegal memory
> accesses.
>
> The patched versions 0.9.7 and 0.10.3 use `#[repr(C, packed)]`,
> which guarantees field order.
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems necessary

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Jul 25, 2024
Merged via the queue into linebender:main with commit 9af2072 Jul 25, 2024
20 checks passed
@waywardmonkeys waywardmonkeys deleted the address-zerovec-issue branch July 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants