Move to piet-wgsl for rendering #12
Conversation
Removes the piet-gpu and piet-gpu-hal dependencies and updates the rendering code to use piet-wgsl.
| ) | ||
| .unwrap(), | ||
| ); | ||
| self.surface = Some(self.render_cx.create_surface(handle, width, height)); |
There was a problem hiding this comment.
create_surface laundering the unsafety of RawWindowHandle isn't ideal.
Really the ecosystem needs to get their act together and find a safe way to access swapchains from wgpu.
I don't really want to block on it, because afaik the safety comment on literally every call to instance.create_surface is along the lines of "hope this works :)"
There was a problem hiding this comment.
Yeah, I suppose the assumption is that if you're sound on both ends of RawWindowHandle then you're good. Otherwise, there be dragons. Still, it's a pretty nifty solution to this problem that avoids the need to bless a particular windowing library or marshal these types around yourself.
There was a problem hiding this comment.
I think the issue is that the current raw-window-handle doesn't guarantee that the window will be sound to create a swapchain for, whilst wgpu assumes it is.
I don't know when this breaks down, but that's the real concern. It's not just about soundness on each side, it's about the windows having the expected capabilities.
There was a problem hiding this comment.
Relevant wgpu issue: gfx-rs/wgpu#1463
Removes the piet-gpu and piet-gpu-hal dependencies and updates the rendering code to use piet-wgsl.