Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a small emoji picker/selector example #420

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Jul 1, 2024

This depends on:

I have added those as our dependencies; it's unlikely that a release containing those will happen very soon.

Xilem Emoji Picker.

Some notes:

  1. The accessibility of this example probably isn't great. Not sure what to do about this.
  2. Our layout primitives aren't great; I've hacked around a grid layout, but we really need to make a Grid widget/View
  3. The pagination is slightly hacked together - it should really try and give you page numbers. I'm not planning to address this, unless someone provides the algorithm
  4. Emoji only render on systems with a system COLR Emoji font. I know my Android device does, but I don't know if any other systems do? Maybe Windows and some Linux systems? This blocks this PR

This is created for linebender/linebender.github.io#56

@jaredoconnell
Copy link
Contributor

I tested this, and the fonts are not visible on Mac OS. Maybe the font isn't COLR format.

@DJMcNab
Copy link
Member Author

DJMcNab commented Jul 3, 2024

Indeed. This is called out in linebender/linebender.github.io#56, for example.

@DJMcNab DJMcNab marked this pull request as draft July 18, 2024 10:16
@DJMcNab
Copy link
Member Author

DJMcNab commented Jul 18, 2024

Moving this into draft due to the lack of bitmap emoji support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants