feat: do not carry etag on separate downloading when the task from ve…

…ry beginning to avoid precondition failed on separate downloading
lingochamp · Jun 22, 2017 · 51fc925 · 51fc925
1 parent fbbbfcb
commit 51fc925
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/library/src/main/java/com/liulishuo/filedownloader/download/DownloadLaunchRunnable.java b/library/src/main/java/com/liulishuo/filedownloader/download/DownloadLaunchRunnable.java
@@ -431,9 +431,9 @@ private void handleFirstConnected(Map<String, List<String>> requestHeader,
 
         if (isPreconditionFailed) {
             // the file on remote is changed
-            if (acceptPartial) {
+            if (isResumeAvailableOnDB) {
                 FileDownloadLog.w(this, "there is precondition failed on this request[%d] " +
-                        "with old etag[%s] != new etag[%s], but the response code is %d",
+                        "with old etag[%s]、new etag[%s]、response code is %d",
                         id, oldEtag, newEtag, code);
             }
 
@@ -560,6 +560,10 @@ private void fetchWithMultipleConnection(final List<ConnectionModel> connectionM
         }
 
         long totalOffset = 0;
+
+        // why not with etag when not resume from the database? because do this can avoid
+        // precondition failed on separate downloading.
+        final boolean withEtag = isResumeAvailableOnDB;
         for (ConnectionModel connectionModel : connectionModelList) {
             totalOffset += (connectionModel.getCurrentOffset() - connectionModel.getStartOffset());
 
@@ -584,7 +588,7 @@ private void fetchWithMultipleConnection(final List<ConnectionModel> connectionM
                     .setConnectionIndex(connectionModel.getIndex())
                     .setCallback(this)
                     .setUrl(url)
-                    .setEtag(etag)
+                    .setEtag(withEtag ? etag : null)
                     .setHeader(userRequestHeader)
                     .setWifiRequired(isWifiRequired)
                     .setConnectionModel(connectionProfile)