Refactor ES addition logic in Destination #12625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a second take on #12427, which avoided a theoretical/correctness issue around overwritting new ES addresses with stale data. We had to revert that in #12589 because the change introduced a bug, by returning early when the ES had no addresses and failed to properly initiallize `addesses` for the portPublisher. This just removes the early return.
adleong
approved these changes
May 21, 2024
| newAddressSet.Addresses[id] = addr | ||
| newAddressSet.LocalTrafficPolicy = pp.localTrafficPolicy | ||
| if _, ok := newAddressSet.Addresses[id]; !ok { | ||
| newAddressSet.Addresses[id] = addr |
There was a problem hiding this comment.
I notice that the assignment of newAddressSet.LocalTrafficPolicy = pp.localTrafficPolicy has been removed. According to my reading of endpointSliceToAddresses, the newAddressSet will always have the traffic policy from pp anyway, so this assignment was redundant. Is that correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second take on #12427, which avoided a theoretical/correctness issue around overwritting new ES addresses with stale data.
We had to revert that in #12589 because the change introduced a bug, by returning early when the ES had no addresses and failed to properly initiallize
addessesfor the portPublisher.This just removes the early return.