Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): update click version #42

Merged
merged 2 commits into from
Feb 14, 2023
Merged

chore(readme): update click version #42

merged 2 commits into from
Feb 14, 2023

Conversation

noelmcloughlin
Copy link
Contributor

This PR bumps up click version

Copy link
Member

@sierra-moxon sierra-moxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test this is a non-breaking change.

@noelmcloughlin
Copy link
Contributor Author

I'm not sure either. According to semver.org the change from 8.0 to 8.1 should be safe as long as click respects this convention.

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backwards compatible manner
PATCH version when you make backwards compatible bug fixes

https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0

@sierra-moxon
Copy link
Member

apologies, I think I merged in a change ahead of this one that requires you to fix the merged conflict on the command line.

@sierra-moxon sierra-moxon self-requested a review February 13, 2023 16:52
@noelmcloughlin
Copy link
Contributor Author

np, thanks @sierra-moxon

@sierra-moxon sierra-moxon merged commit 7e54e7f into linkml:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants