Add poetry virtual env creation to doc, update commands to reflect examples, partially fixes #963, fixes #962 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sierra-moxon
requested review from
hrshdhgd and
cmungall
and removed request for
hrshdhgd
sierra-moxon
changed the title
hrshdhgd
reviewed
Sep 15, 2022
cookiecutter.json
Outdated
| "__author": "{{cookiecutter.full_name}} <{{cookiecutter.email}}>", | ||
| "license": ["MIT", "BSD-3", "GNU GPL v3.0", "Apache Software License 2.0"], | ||
| "google_analytics_gtag": "G-2SYBSJVZ23", | ||
| "main_schema_class": "Person", | ||
| "create_python_classes": ["Yes", "No"], | ||
| "use_schemasheets": [ | ||
| "Yes", | ||
| "No (next two questions are ignored)" | ||
| "No (next two questions are ignored)", |
There was a problem hiding this comment.
I have already fixed this and the PR was merged to main this morning but the (next two questions are ignored) should not be present. This is because the whole string "No (next two questions are ignored)" becomes a value and an if condition e.g. {% if cookiecutter.use_schemasheets == "No" %} won't work. It'll have to be {% if cookiecutter.use_schemasheets == "No (next two questions are ignored)" %} which is weird. You might want to pull down from main to this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.