M3-5546: IP address font color on Firefox in dark mode #8008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevDW
approved these changes
Oct 26, 2021
HanaXu
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if you go to any Linode Detail page on Firefox in dark mode, the font color for "IP Addresses" and "SSH Access" should be white but instead, it's showing up as black.
This is due to a known Firefox bug that will decide that a font is colored if it contains SVG glyphs (which surprise, Source Code Pro does). The latest release should've fixed this issue but the font is still showing up as black for me after updating the files.
After some sleuthing, I decided to test out Ubuntu Monospace as an alternative to Source Code Pro. I tested the font color on Chrome, Firefox, Safari, Edge, Opera, and Vivaldi with no issues.
Links:
How to test
develop, use Firefox and go to any Linode Detail page in dark mode to verify the problem