Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): add missing user command #43

Closed
wants to merge 1 commit into from

Conversation

KortanZ
Copy link
Contributor

@KortanZ KortanZ commented Apr 18, 2024

There is only a user command option in config, this patch register the configed user command to nvim. Tested localy on windows.

@linrongbin16
Copy link
Owner

linrongbin16 commented Apr 18, 2024

I think the dispatcher.update could be auto-triggered when user open a workspace/file, or save the file. So the command is not useful, correct?

In the original idea, I want to use the Gentags command to:

  1. Show the generated & cached tags files by this plugin
  2. Allow user manual delete these cached tags files
  3. Allow user to trigger a GC (garbage collection) on these cached tags files, to avoid too much disk usage.

@KortanZ
Copy link
Contributor Author

KortanZ commented Apr 18, 2024

I think the dispatcher.update could be auto-triggered when user open a workspace/file, or save the file. So the command is not useful, correct?

My fault, actuall there is an in progress proposal PR that I've use locally which i add a config option that control whether the auto update is on. My tagfile is relatively large, around 1GiB, and it's really unusable if auto-update happened on every file i opened and modified. I just need a commad to manually trigger the update, and i find the option :-)

In the original idea, I want to use the Gentags command to:
Show the generated & cached tags files by this plugin
Allow user manual delete these cached tags files
Allow user to trigger a GC (garbage collection) on these cached tags files, to avoid too much disk usage.

Now i see. Is it better that we removed the command option and give user a fixed command set, like :GenTags show, :GenTags update?

@linrongbin16
Copy link
Owner

@KortanZ ,

Now i see. Is it better that we removed the command option and give user a fixed command set, like :GenTags show, :GenTags update?

Yes, it's a great design.

@KortanZ
Copy link
Contributor Author

KortanZ commented Apr 18, 2024

Yes, it's a great design.

Great! Now i know how to implement command properly.

Anyway, this PR could close now. Thank you :D

@KortanZ KortanZ closed this Apr 18, 2024
@KortanZ KortanZ deleted the KortanZ-patch-usrcmd branch April 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants