Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add examples "deepin-anything vfs monitor" #75

Merged

Conversation

Kingtous
Copy link
Contributor

@Kingtous Kingtous commented Dec 23, 2022

@github-actions
Copy link

github-actions bot commented Dec 23, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Kingtous
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

deepin-bot bot added a commit to linuxdeepin/cla that referenced this pull request Dec 23, 2022
@BLumia
Copy link
Member

BLumia commented Dec 24, 2022

For the license check CI, you need to add license header to newly added files. See here for the REUSE tool report. Something like:

// SPDX-FileCopyrightText: 2022 Your Name <[email protected]>
//
// SPDX-License-Identifier: GPL-3.0-or-later

@Kingtous
Copy link
Contributor Author

Kingtous commented Dec 24, 2022

For the license check CI, you need to add license header to newly added files. See here for the REUSE tool report. Something like:

// SPDX-FileCopyrightText: 2022 Your Name <[email protected]>
//
// SPDX-License-Identifier: GPL-3.0-or-later

Is there any automated tool to complete it, or should I do these jobs manually? :)

I've also noticed the commit check ci also complained empty commit body, should I squash some commits and add some commits detail?

@BLumia
Copy link
Member

BLumia commented Dec 24, 2022

Is there any automated tool to complete it, or should I do these jobs manually? :)

You can check out the How to become REUSE-compliant tutorial :)

should I squash some commits and add some commits detail?

We don't require PR to be just contain a single commit, the commitlint check is a per-commit basis check to ensure if commit message follows the Conventional Commits specification.

We can manually squash merge PR though, but personally, I suggest you modify the commit message so it could contain useful information. An interactive rebase could help you get the job done.

opt: add cmake config

opt: add demo

feat: integrate vfs event
feat: chain block device model & vfs event model

feat: export, event filter ui

feat: filters
opt: change to gpl3

refactor: reuse

refactor: adjust license
This commits allows
- close the application safely.
- fix dpkg build package issue.
- add tooltip to long text
- ignore empty tooltip
- support dynamic patition update
- absolute path for mount point
- format the code to Deepin style
- ignore prefix for empty source or dest
@Kingtous
Copy link
Contributor Author

Any update on this? :)

This commit also uses the root mount point for all devices.
This commits also fixes mount data for root device
This commit fixes the order of original event queue.
Copy link
Contributor

@wangrong1069 wangrong1069 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants