Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal error when building for x64-osx #9

Open
lionkor opened this issue Mar 10, 2022 · 3 comments
Open

Fatal error when building for x64-osx #9

lionkor opened this issue Mar 10, 2022 · 3 comments
Labels
build error A build that should work has failed

Comments

@lionkor
Copy link
Owner

lionkor commented Mar 10, 2022

When building x64-osx (vcpkg):

/Users/vagrant/Data/buildtrees/commandline/src/a4454e07a9-613e01ad85.clean/commandline.cpp:11:10: fatal error: 'conio.h' file not found
#include <conio.h>
         ^~~~~~~~~
1 error generated.

Originally posted by @JackBoosY in microsoft/vcpkg#23471 (comment)
@lionkor
Copy link
Owner Author

lionkor commented Mar 10, 2022

This should not happen. While it's okay for vcpkg not to support macos here for now, I'd like this to be resolved and macos to be supported properly.

@lionkor lionkor added the build error A build that should work has failed label Mar 10, 2022
@effleurager
Copy link

This was solved by #24 AFAICT, it's just not been part of any release yet — they'd likely reverse the support ban afterwards.

@lionkor
Copy link
Owner Author

lionkor commented Oct 13, 2023

Should be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build error A build that should work has failed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@effleurager @lionkor