-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lionkor-commandline] Add new port #23471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/commandline/vcpkg.json b/ports/commandline/vcpkg.json
index 93c3393..52b5dd8 100644
--- a/ports/commandline/vcpkg.json
+++ b/ports/commandline/vcpkg.json
@@ -1,8 +1,8 @@
-{
- "name": "commandline",
- "version-semver": "1.0.0",
- "description": "A C++ commandline for use in servers and chat software. Provides very simple asynchronous input/output.",
- "homepage": "https://github.com/lionkor/commandline/",
- "license": "MIT",
- "supports": "static"
-}
+{
+ "name": "commandline",
+ "version-semver": "1.0.0",
+ "description": "A C++ commandline for use in servers and chat software. Provides very simple asynchronous input/output.",
+ "homepage": "https://github.com/lionkor/commandline/",
+ "license": "MIT",
+ "supports": "static"
+}
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index d87a108..c82f668 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,6 +1472,10 @@
"baseline": "3.7",
"port-version": 0
},
+ "commandline": {
+ "baseline": "1.0.0",
+ "port-version": 0
+ },
"comms": {
"baseline": "3.4.0",
"port-version": 1
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/commandline/portfile.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index d87a108..c82f668 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,6 +1472,10 @@
"baseline": "3.7",
"port-version": 0
},
+ "commandline": {
+ "baseline": "1.0.0",
+ "port-version": 0
+ },
"comms": {
"baseline": "3.4.0",
"port-version": 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for commandline but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: 58aa6f7b74d8b1a876f3a906b65a7f0b2421022c
-- New SHA: 0a624b93bb7e086e520b067dfa82a6c50916c2b4
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for commandline but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: 0a624b93bb7e086e520b067dfa82a6c50916c2b4
-- New SHA: d768b284ac7cdf5d13b7f32a24217bfff2632332
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
When building x64-osx:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for commandline but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: d768b284ac7cdf5d13b7f32a24217bfff2632332
-- New SHA: 18e1e8483a0a5b81a25fd0efcc87403dcbf64432
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
@JackBoosY marked osx as unsupported |
Waiting for test results. |
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for commandline but no changes to version or port version.
-- Version: 1.0.0
-- Old SHA: 18e1e8483a0a5b81a25fd0efcc87403dcbf64432
-- New SHA: 518c484843653c6e10980b19997d698fcc046c97
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
@JackBoosY Plz tell me if there is a way to disable |
Thanks for the PR! It's fine to just delete Additionally, the name of this library is extremely generic and there isn't a long history of associating that name with this library. Could you please rename the port to something more unique like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment.
…ne/add-install.patch
@ras0219-msft No problem, I've just renamed everything via gh interface. hope it works :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..126d188 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,7 +1472,7 @@
"baseline": "3.7",
"port-version": 0
},
- "lionkor-commandline": {
+ "commandline": {
"baseline": "1.0.0",
"port-version": 0
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..126d188 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,7 +1472,7 @@
"baseline": "3.7",
"port-version": 0
},
- "lionkor-commandline": {
+ "commandline": {
"baseline": "1.0.0",
"port-version": 0
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..732196e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,10 +1472,6 @@
"baseline": "3.7",
"port-version": 0
},
- "lionkor-commandline": {
- "baseline": "1.0.0",
- "port-version": 0
- },
"comms": {
"baseline": "3.4.0",
"port-version": 1
@@ -4192,6 +4188,10 @@
"baseline": "4754bee2d8eb3",
"port-version": 2
},
+ "lionkor-commandline": {
+ "baseline": "1.0.0",
+ "port-version": 0
+ },
"live555": {
"baseline": "2021-12-18",
"port-version": 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..732196e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,10 +1472,6 @@
"baseline": "3.7",
"port-version": 0
},
- "lionkor-commandline": {
- "baseline": "1.0.0",
- "port-version": 0
- },
"comms": {
"baseline": "3.4.0",
"port-version": 1
@@ -4192,6 +4188,10 @@
"baseline": "4754bee2d8eb3",
"port-version": 2
},
+ "lionkor-commandline": {
+ "baseline": "1.0.0",
+ "port-version": 0
+ },
"live555": {
"baseline": "2021-12-18",
"port-version": 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 6756062..732196e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1472,10 +1472,6 @@
"baseline": "3.7",
"port-version": 0
},
- "lionkor-commandline": {
- "baseline": "1.0.0",
- "port-version": 0
- },
"comms": {
"baseline": "3.4.0",
"port-version": 1
@@ -4192,6 +4188,10 @@
"baseline": "4754bee2d8eb3",
"port-version": 2
},
+ "lionkor-commandline": {
+ "baseline": "1.0.0",
+ "port-version": 0
+ },
"live555": {
"baseline": "2021-12-18",
"port-version": 0
* master: (64 commits) [baseline] [python3] fix bz2(d) search on linux (microsoft#23525) [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042) [earcut.hpp] New port (microsoft#23507) [libssh2] Fix deleted configfiles (microsoft#23509) [python3] Update to Python 3.10.2. (microsoft#23156) [qt5-webengine] Fix apply patch failed (microsoft#23484) [llvm] Fix LLVM install for 'utils' feature (microsoft#23399) [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357) [GTL] Add new port (microsoft#23400) [raylib] Fix cannot find -lglfw on Linux (microsoft#23348) [yato] fix arm build by updating (microsoft#23406) [ois] fix pkgconfig file not installed on windows (microsoft#23426) Fix the dependency of installing arrow with the parquet feature (microsoft#23423) [libjpeg-turbo] Fix usage when building static (microsoft#23427) [sentencepiece] Clarify supported triplets (microsoft#23438) [zpp-bits] Add new port (microsoft#23458) [lionkor-commandline] Add new port (microsoft#23471) [libde265] fix static linkage (microsoft#23479) [libheif] fix license (microsoft#23480) [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487) ...
Describe the pull request
What does your PR fix?
Fixes [New Port Request] commandline #23459
Which triplets are supported/not supported? Have you updated the CI baseline?
<all / linux, windows, ...>, <Yes/No>
Does your PR follow the maintainer guide?
Your answer
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?<Yes / I am still working on this PR>
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/