[HPX] Don't remove HPXCacheVariables.cmake during install

[hkaiser]

Describe the pull request

• What does your PR fix?

  Fixes project builds that depend on HPX installed using vcpkg

• Which triplets are supported/not supported? Have you updated the CI baseline?

  all, Yes

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/hpx/vcpkg.json

Valid values for the license field can be found in the documentation

[autoantwort]

This file contains absolute paths. You must replace all absolute paths by relative ones.

[hkaiser]

This file contains absolute paths. You must replace all absolute paths by relative ones.

Could you be more specific please? What file? What paths? And how do you suggest replacing those? The only thing this PR does is to remove a line. Nothing else has changed.

[autoantwort]

Could you be more specific please? What file?

HPXCacheVariables.cmake

And how do you suggest replacing those?

You can use vcpkg_replace_strings() to do that.

[BillyONeal]

@hkaiser To clarify, we need to prevent absolute paths from making it in to the output, because when a cached package is restored on a different machine, all those paths are broken. Ideally, that file would be written to use paths relative to ${CMAKE_CURRENT_LIST_DIR} or something similar.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for hpx but no changes to version or port version.
-- Version: 1.7.1#4
-- Old SHA: 815641d6119376c546119a841f6c035e8f27b8da
-- New SHA: 6441b19100ce57830f43b5a45c0cde2418c640ec
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5cf60186a241e84e8232641ee973395d4fde90e1 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/h-/hpx.json b/versions/h-/hpx.json
index 5736779..9eec62d 100644
--- a/versions/h-/hpx.json
+++ b/versions/h-/hpx.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "6441b19100ce57830f43b5a45c0cde2418c640ec",
+      "git-tree": "815641d6119376c546119a841f6c035e8f27b8da",
       "version-semver": "1.7.1",
       "port-version": 4
     },

[hkaiser]

@hkaiser To clarify, we need to prevent absolute paths from making it in to the output, because when a cached package is restored on a different machine, all those paths are broken. Ideally, that file would be written to use paths relative to ${CMAKE_CURRENT_LIST_DIR} or something similar.

@BillyONeal this has been resolved now. Thanks!

[hkaiser]

@BillyONeal will this be merged at some point?

[BillyONeal]

@BillyONeal will this be merged at some point?

Sorry for the delay, I just poked the person "on call" for merging things to confirm they're OK with it.