New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure logger and force "DEBUG" level in debug mode #1119

Merged

provinzkraut merged 1 commit into main from debug-logging-config

Jan 31, 2023

Member

provinzkraut commented Jan 31, 2023

Implement the proposal made in #976 (comment).

Configure a starlite logger in debug mode if no LoggingConfig was given, and logging_config was not explicitly set to None
Set the level of the starlite logger to DEBUG when in debug mode

This generally makes the use of debug more intuitive, especially in combination with #976: Setting debug=True will the result in exceptions being logged without having to specify any additional configuration.

PR Checklist

Have you followed the guidelines in CONTRIBUTING.md?
Have you got 100% test coverage on new code?
Have you updated the prose documentation?
Have you updated the reference documentation?


          Configure logger and force "DEBUG" level in debug mode

01c9d39

provinzkraut requested a review from a team

January 31, 2023 13:47

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

100.0% Coverage
0.0% Duplication

Goldziher approved these changes

View reviewed changes

provinzkraut merged commit 10bdf77 into main

provinzkraut deleted the debug-logging-config branch

January 31, 2023 14:33

provinzkraut mentioned this pull request

Bug: debug mode doesn't work #1476

Closed

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet