Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_coverage.sh:22-24: The coverage script is ignoring... #18

Closed
0pdd opened this issue Feb 24, 2019 · 1 comment
Closed

check_coverage.sh:22-24: The coverage script is ignoring... #18

0pdd opened this issue Feb 24, 2019 · 1 comment
Milestone
1.0.0

Comments

@0pdd
Copy link

0pdd commented Feb 24, 2019

The puzzle 16-e0d2cf8f from #16 has to be resolved:

go-gitlint/check_coverage.sh

Lines 22 to 24 in b52f151

# @todo #16 The coverage script is ignoring packages that are not tested
# at all (0% coverage). It should be fixed so that all packages are
# tested (except for main).

The puzzle was created by @llorllale on 24-Feb-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Feb 24, 2019
@llorllale
(#16) Add commit filters (#17)
b52f151
@0pdd 0pdd mentioned this issue Feb 24, 2019
Closed
@llorllale llorllale added this to the 1.0.0 milestone Feb 24, 2019
llorllale added a commit that referenced this issue Feb 26, 2019
@llorllale
(#18) Fix ignore of untested packages in coverage check
ed4ea05
llorllale added a commit that referenced this issue Feb 26, 2019
@llorllale
(#18) Fix ignore of untested packages in coverage check
6343916
@llorllale llorllale mentioned this issue Feb 26, 2019
Merged
llorllale added a commit that referenced this issue Feb 26, 2019
@llorllale
(#18) Fix ignore of untested packages in coverage check (#19)
8162e43
@0pdd 0pdd closed this as completed Feb 26, 2019
@0pdd
Copy link
Author

0pdd commented Feb 26, 2019

The puzzle 16-e0d2cf8f has disappeared from the source code, that's why I closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@llorllale @0pdd