Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main.go:10-12: The path should be passed in as a command... #9

Closed
0pdd opened this issue Feb 18, 2019 · 2 comments
Closed

main.go:10-12: The path should be passed in as a command... #9

0pdd opened this issue Feb 18, 2019 · 2 comments
Milestone
1.0.0

Comments

@0pdd
Copy link

0pdd commented Feb 18, 2019

The puzzle 4-2f6700f4 from #4 has to be resolved:

go-gitlint/cmd/go-gitlint/main.go

Lines 10 to 12 in 2738cc2

// @todo #4 The path should be passed in as a command line
// flag instead of being hard coded. All other configuration
// options should be passed in through CLI as well.

The puzzle was created by @llorllale on 18-Feb-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Feb 18, 2019
@llorllale
(#4) Read the commit log (#7)
2738cc2
@0pdd 0pdd mentioned this issue Feb 18, 2019
Closed
@llorllale llorllale added this to the 1.0.0 milestone Feb 21, 2019
llorllale added a commit that referenced this issue Mar 2, 2019
@llorllale
(#9) Command line flags
e9c2b56 
* Filters and repo path are specified via command
  line flags
* Can also specify flags via '.gitlint' file in
  $PWD (command line flags take precedence).
  The format of this file is the same as command
  line flags, where each is on a separate line.
@llorllale llorllale mentioned this issue Mar 2, 2019
Merged
llorllale added a commit that referenced this issue Mar 2, 2019
@llorllale
(#9) Command line flags (#22)
4be918f 
* Filters and repo path are specified via command
  line flags
* Can also specify flags via '.gitlint' file in
  $PWD (command line flags take precedence).
  The format of this file is the same as command
  line flags, where each is on a separate line.
@0pdd
Copy link
Author

0pdd commented Mar 2, 2019

The puzzle 4-2f6700f4 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Mar 2, 2019
@0pdd 0pdd mentioned this issue Mar 2, 2019
Open
@0pdd
Copy link
Author

0pdd commented Mar 2, 2019

@0pdd the puzzle #23 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@llorllale @0pdd