Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#34) Remove issues.Filter() #35

Merged
merged 1 commit into from
Mar 3, 2019
Merged

(#34) Remove issues.Filter() #35

merged 1 commit into from
Mar 3, 2019

Conversation

llorllale
Copy link
Owner

PR for #34:
Removed issues.Filter() and placed all configuration variables inside main package.

@llorllale llorllale modified the milestone: 1.0.0 Mar 3, 2019
@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #35 into master will decrease coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #35      +/-   ##
=======================================
- Coverage   85.32%   84%   -1.33%     
=======================================
  Files           4     4              
  Lines         109   100       -9     
=======================================
- Hits           93    84       -9     
  Misses          8     8              
  Partials        8     8
Impacted Files Coverage Δ
internal/issues/filters.go 86.66% <ø> (-3.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bb99a...706c48e. Read the comment docs.

@llorllale llorllale merged commit c4374b4 into master Mar 3, 2019
@llorllale llorllale deleted the 34 branch March 3, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant