suppress repack commands' error message #1593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangxifan
requested changes
Mar 8, 2024
| @@ -57,12 +57,17 @@ int read_pcf(const char* fname, PcfData& pcf_data) { | |||
| pcf_data.set_io_pin(io_id, pin_name); | |||
| } else if (word[0] == COMMENT) { // if it's a comment | |||
| break; // or ignore the full line comment and move on | |||
| } else if (word.find("set_clk") == 0 || word.find("set_reset") == 0) { | |||
There was a problem hiding this comment.
My suggestion is to add a new option --reduce_error_to_warning to the read_pcf command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Arkangel, the repack_dc file can be automatically generated from commands such as "set_clk" and "set_reset" in the PCF file. Therefore, some modifications are made in this PR to suppress the error messages for these two commands while reading pcf file.