Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trim.js #443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

adelin-mcbsoft
Copy link

@adelin-mcbsoft adelin-mcbsoft commented Apr 9, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Added null-byte to the trimmable characters list of the trim() function.
PHP does trim null-byte, while the current implementation of JS trim() does not.
Didn't credit myself, no need to.

Added null-byte to the trimmable characters list.
@kvz
Copy link
Collaborator

kvz commented Apr 4, 2024

Thanks for the contribution. And sorry for the late reply, can you add a test for ensuring this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants