Feat: added target => namespace support + ECS compatibility #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
changed the title
kares
changed the title
andsel
approved these changes
Jul 16, 2021
| @@ -1,5 +1,9 @@ | |||
| ## 1.1.0 | |||
| - Feat: added target => namespace support + ECS compatibility [#7](https://github.com/logstash-plugins/logstash-codec-csv/pull/7) | |||
There was a problem hiding this comment.
Suggested change
| - Feat: added target => namespace support + ECS compatibility [#7](https://github.com/logstash-plugins/logstash-codec-csv/pull/7) | |
| - Added `target` configuration option to namespace the read CSV field and added ECS compatibility [#7](https://github.com/logstash-plugins/logstash-codec-csv/pull/7) |
|
|
||
| it "extract all the values" do | ||
| it "return an event from CSV data" do | ||
| event_count = 0 |
There was a problem hiding this comment.
event_count is used as an execution guard, sop maybe a boolean could expose better the intention to verify the codec execution.
event_decoded = false
codec.decode(data) do |event|
event_decoded = true
...
end
expect( event_decoded ).to be true
karenzone
approved these changes
Jul 16, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're introducing a
target => ...configuration option for the codec, to aid ECS support.When
targetisn't set in ECS mode, we do the usual info log message.