Track temp dirs and remove when staled. #30
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly focuses on two changes:
Introduced
temp_files
container (FileRepository
locks for thread safety) to keep and track all rotated files. When file is removed from track list?When file and tempdir are physically deleted?
file.delete!
) didn't succeed, means third party process (especially on Windows, security scanners) is keeping open the IO and Logstash removes the file. Physically, for this case, file will be deleted but temp dir stays. - both temp dir is deleted.asdas