Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable glob #1581

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enable glob #1581

wants to merge 3 commits into from

Conversation

semkagtn
Copy link

@semkagtn semkagtn commented May 26, 2020

Some configuration files contain application version in their paths. So you have to explicitly list all the versions. For example: https://github.com/lra/mackup/blob/master/mackup/applications/intellijidea.cfg

I have add the support of globing to solve this problem. You have to explicitly enable this feature to use it. So there are no issues with backward compatibility.

Related issues:
#1440
#1436

@nesk
Copy link
Contributor

nesk commented Jan 7, 2021

@lra Is there anything preventing the merge of this PR? It really could be handy for some softwares.

@lra
Copy link
Owner

lra commented Jan 7, 2021

It's a big change with a lot of edge cases to test.
If I just merge this without testing all the edge cases (ideally in unit tests), I take the risk of selling a feature that's not gonna work.
Including tests would help speed this up.

@JimJafar
Copy link

Is this dead, or has globbing been enabled elsewhere?
BetterTouchTool is using versioned filenames now like:

btt_data_store.version_3_553_build_1693
btt_data_store.version_3_553_build_1693-shm
btt_data_store.version_3_553_build_1693-wal

@joshmedeski
Copy link
Contributor

@EvilJimJafar no one has taken ownership of this yet, it's a pretty significant feature that needs solid testing before it would be published. Let us know if you want to implement this feature.

@jneuendorf
Copy link

I have forked @semkagtn's repo and added a consecutive PR #1807. Please let me know what you think, e.g if more testing is needed - but let's discuss over there ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants