Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GitHub CLI #2000

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for GitHub CLI #2000

wants to merge 3 commits into from

Conversation

Wxh16144
Copy link
Contributor

All submissions

Adding/updating Application X Support

  • This PR is only for one application
  • It has been added to the list of supported applications in the README
  • Changes have been added to the WIP section of the CHANGELOG
  • Syncing does not break the application
  • Syncing does not compete with any syncing functionality internal to the application
  • The configuration syncs the minimal set of data
  • No file specific to the local workstation is synced
  • No sensitive data is synced

Improving the Mackup codebase

  • My submission passes the tests
  • I have linted the code locally prior to submission
  • I have written new tests as applicable
  • I have added an explanation of what the changes do

lra
lra approved these changes Feb 22, 2024
View reviewed changes
Copy link
Owner

@lra lra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lra
Copy link
Owner

lra commented Feb 22, 2024

Not sure what's going on, but I can't merge:
Capture d’écran 2024-02-22 à 15 02 21

@Kol9yN
Copy link

Kol9yN commented Jun 7, 2024

Any news about make it support? ;)

@Wxh16144
Copy link
Contributor Author

I'm sorry, I overlooked too many emails. I have resolved some conflicts and can review my code at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lra lra lra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wxh16144 @lra @Kol9yN