Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add terraform-cli support #2017

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jdvivar
Copy link
Contributor

@jdvivar jdvivar commented Apr 16, 2024

This PR adds support for Terraform CLI, here are explained what directories are included: https://developer.hashicorp.com/terraform/cli/config/config-file

Local test run ✅

I was initially not able to test the changes locally, the instructions say:

from the top-most folder (mackup) run make develop that replaces the currently installed mackup with the local modified one

from https://github.com/lra/mackup/blob/master/doc/README.md#locally-test-an-application-before-submitting-a-pull-request

However make develop returns:

$ make develop
make: *** No rule to make target `develop'.  Stop.

The correct instructions should let you know you should use poetry instead. Installing with brew install poetry (rather that pipx), then running poetry install --with dev, then poetry run mackup with whatever option you want to test, in my case just poetry run mackup backup --force. So update the instructions and/or link to the docs/developing.md file.

It correctly syncs my Terraform CLI files when running locally.

Test Results ✅

$ make test
poetry install --with dev
Installing dependencies from lock file

No dependencies to install or update

Installing the current project: mackup (0.8.40)
poetry run pytest
========================================================= test session starts ==========================================================
platform darwin -- Python 3.12.3, pytest-7.4.4, pluggy-1.4.0
rootdir: /Users/danielvivar/Repos/mackup
collected 30 items                                                                                                                     

tests/test_config.py .............                                                                                               [ 43%]
tests/test_main.py ..                                                                                                            [ 50%]
tests/test_utils.py ...............                                                                                              [100%]

========================================================== 30 passed in 0.16s ==========================================================

All submissions

Adding/updating Application X Support

  • This PR is only for one application
  • It has been added to the list of supported applications in the README
  • Changes have been added to the WIP section of the CHANGELOG
  • Syncing does not break the application
  • Syncing does not compete with any syncing functionality internal to the application
  • The configuration syncs the minimal set of data
  • No file specific to the local workstation is synced
  • No sensitive data is synced

Improving the Mackup codebase

  • My submission passes the tests
  • I have linted the code locally prior to submission
  • I have written new tests as applicable
  • I have added an explanation of what the changes do

@Kol9yN
Copy link

Kol9yN commented Sep 7, 2024

Bump! @lra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants