Add an ability to ignore a field during serialization #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now returning nil from the field's reverse block causes an exception
because of using `setObject:` syntax for NSDictionary (can't have nil
in collections). This makes impossible to ignore a field in the
serialization representation:
```
[mapping mapKeyPath:@"ip" toProperty:@"ipAddress"
withValueBlock:^id(NSString *key, id value) {
return value;
} reverseBlock:^id(id value) {
return nil; //causes an exception later
}];
```
This fix makes the code above work as expected: the keyPath will be
ignored during `[EKSerializer serializeObject:self
withMapping:mapping];`
|
Thanks! Can i ask you to write unit test for this case? |
added 3 commits
February 9, 2017 15:57
Contexts named * using EKMappingBlocks * using mapping blocks with nil value weren't executing beause the `should` clauses inside of them were written outside of the `specify` blocks. Fixed. Had to modify "when male" context as well as I moved its `beforeEach` block up.
|
@DenHeadless done. Also made some fixes for test that weren't executing because of incorrect Kiwi syntax. +a bit of cosmetics :-) |
|
Thanks again! I've cut 0.20.1 release with these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently returning
nilfrom the field's reverse block causes an exceptionbecause of using
setObject:syntax for NSDictionary (can't havenilin collections). This makes impossible to ignore a field in the
serialization representation:
This fix makes the code above work as expected: the keyPath will be
ignored during
[EKSerializer serializeObject:self withMapping:mapping];