Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: change panel background color based on touching window #44

Closed
dr460nf1r3 opened this issue May 4, 2024 · 6 comments
Closed
Labels
enhancement New feature or request

Comments

@dr460nf1r3
Copy link

Heya!
Latte used to support changing panel background color based on whatever window was touching it.
If I remember correctly, this used to source a specific color. The current feature of drawing it from the system works well, however, it would be nice to be able to let the panel become translucent again when no window touches it.

Intended purpose:
image

Being able to have aligned colors between top panel and titlebar/window when windows are maximized.

image

Then having it opaque would make the top bar less dominant while not having windows maximized.

Thanks!

@luisbocanegra
Copy link
Owner

Currently in v0.5.1 you can create and switch between different presets based on the state of the panel/windows:

  • Normal
  • Floating
  • Maximized window is shown

I remember seeing a panel property that returns whether or not a window is touching the panel, will look into adding that to preset auto-loading.

Note that this feature only looks right as long as the application follows the current Plasma colors, taking colors from the actual window would be an interesting challenge, but will require C++/Qt and understanding Plasma/KWin code (I barely know C++). That deserves its own issue 🙂

@luisbocanegra luisbocanegra added the enhancement New feature or request label May 4, 2024
@dr460nf1r3
Copy link
Author

dr460nf1r3 commented May 4, 2024

Actually having the color changed depending on whether the window maximized would already suffice for my use case - if I understood you correctly that's already possible by creating profiles (if yes, I didn't RTFM correctly 😅) ?

Edit: yes it actually does say it right at the beginning, but I didn't make the connection to using it that way. Though, I can imagine situations where windows are touching the panel where a window isn't maximized and having it changed would still make sense: using a split screen with one window being used for research, while the other one is used for eg. a text editor. Especially when not having two screens available, it's a common use case for me.

@luisbocanegra
Copy link
Owner

Edit: yes it actually does say it right at the beginning, but I didn't make the connection to using it that way.

Yeah, maybe a better description of some of the features in the README and a bunch of "What is this" labels/buttons through the widget settings, or even a video tutorial could help.

luisbocanegra added a commit that referenced this issue May 15, 2024
- Allow loading a preset when a window is touching the panel #44
- Now is possible to have assign a preset for all states and they are loaded with the following priority:

1. Normal
2. Floating
3. Touching
4. Maximized
luisbocanegra added a commit that referenced this issue May 15, 2024
- Allow loading a preset when a window is touching the panel #44
- Now is possible to have assign a preset for all states and they are loaded with the following priority:

1. Normal
2. Floating
3. Touching
4. Maximized
luisbocanegra added a commit that referenced this issue May 15, 2024
- Allow loading a preset when a window is touching the panel #44
- Now is possible to have assign a preset for all states and they are loaded with the following priority (lowest to highest):

1. Normal
2. Floating
3. Touching
4. Maximized
@luisbocanegra
Copy link
Owner

Done in deb615b

@dr460nf1r3
Copy link
Author

Awesome! Could you push this as a new release in KDE's store? 😊

@luisbocanegra
Copy link
Owner

Will do later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants