Deprecate the ability to define static observedAttributes as a map of attribute names to attribute handlers for non-decorator users, and instead create a new static observedAttributeHandlers for that purpose.
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a map of attribute names to attribute handlers for non-decorator users, and instead create a new `static observedAttributeHandlers` for that purpose. This keeps the type of `static observedAttributes` clean and aligned with the DOM spec, while the new `static observedAttributeHandlers` has the type definition for the library-specific feature. Plus this prevents type issues downstream because the `@element` decorator (callable as a function when not using decorators) coerces the object format into the standard array format, yet the object type will still sppear in subclasses despite that it is never an object in subclasses.
- deprecation: `static observedAttributes = {}` is deprecated, and only the standard `static observedAttributes = []` should be used. The object format will be removed in a breaking version bump.
- infra: Unrestrict the `typescript` version so we can keep it updated with other packages in the lume repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the type of
static observedAttributesclean and aligned with the DOM spec, while the newstatic observedAttributeHandlershas the type definition for the library-specific feature. Plus this prevents type issues downstream because the@elementdecorator (callable as a function when not using decorators) coerces the object format into the standard array format, yet the object type will still sppear in subclasses despite that it is never an object in subclasses.deprecation:
static observedAttributes = {}is deprecated, and only the standardstatic observedAttributes = []should be used. The object format will be removed in a breaking version bump.infra: Unrestrict the
typescriptversion so we can keep it updated with other packages in the lume repo.