Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #240

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Update README.md #240

merged 4 commits into from
Sep 10, 2023

Conversation

Jpxe
Copy link
Contributor

@Jpxe Jpxe commented Sep 10, 2023

I just installed the debug build on Fedora. I had to do a bit of trail and error to find out I also needed to install Cargo and the Godot export template, as well as extract it in the right directory. These instructions might make it a bit easier.

Luxtorpeda Client Submissions

  • Have you verified that the code changes in the pull request are related to only the items you wish to change?
  • Have you run the build locally and ensured the changes allowed you to launch and play the Steam game?
  • Have you ensured that there is not already a pull request or active feature for the one you are adding?

Copy link
Member

@d10sfan d10sfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good the lines added after the first one for fedora should be common across all distro, mainly about getting the export template and putting it in the right place. If you can update that the rest looks good.

Thanks for the contribution!

@Jpxe
Copy link
Contributor Author

Jpxe commented Sep 10, 2023

How about this? I did som searching for what terminal commands should work for different distros and did some slight text changes as well

Copy link
Member

@d10sfan d10sfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@d10sfan d10sfan merged commit 0cd5892 into luxtorpeda-dev:master Sep 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants