Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always import config via file-URL #19

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Always import config via file-URL #19

merged 1 commit into from
Jul 15, 2021

Conversation

thw0rted
Copy link
Contributor

Fixes #18

For reference, see nodejs/node#34765:

{on non-Windows platforms} the host-relative URL happens to resolve to the same file. But this is coincidence, not guaranteed

I wanted to add a test for this, but wasn't sure how to make one that loads a config file based on defaultConfigFilePaths.

@75lb
Copy link
Member

75lb commented Jul 15, 2021

ahh, well spotted.. don't worry about the test - i'll add that..

@75lb
Copy link
Member

75lb commented Jul 15, 2021

ffs, the tests fail as they are on windows.. I usually test manually on Windows before every release but this one has slipped through.. will update the CI to make sure the test suite gets run on a Windows host too..

@75lb 75lb merged commit e9ad81a into lwsjs:master Jul 15, 2021
@75lb
Copy link
Member

75lb commented Jul 15, 2021

merged and released in lws v4.0.2.. please let me know if you find anything else.. i'll add Windows testing to the CI later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config file resolution fails on Windows
2 participants