This repository has been archived by the owner on May 17, 2024. It is now read-only.
Remove duplicate Hashable conformation #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/duplicate-hashable
branch
from
48d175e
to
174c786
Compare
Reflejo
approved these changes
Jun 9, 2017
Mapper.xcodeproj/project.pbxproj
Outdated
| GCC_WARN_UNDECLARED_SELECTOR = YES; | ||
| GCC_WARN_UNINITIALIZED_AUTOS = YES; | ||
| GCC_WARN_UNUSED_FUNCTION = YES; | ||
| GCC_WARN_UNUSED_VARIABLE = YES; |
There was a problem hiding this comment.
Yea, this is just part of the Xcode 8.3 migration. These settings are fine either way.
keith
force-pushed
the
ks/duplicate-hashable
branch
from
174c786
to
8acf77a
Compare
Swift 4 now has a warning for this, but this is backwards compatible to Swift 3 as well.
keith
force-pushed
the
ks/duplicate-hashable
branch
from
8acf77a
to
9ffacfa
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 4 now has a warning for this, but this is backwards compatible to
Swift 3 as well.