This repository has been archived by the owner on May 17, 2024. It is now read-only.
Update for Swift 4.1 and Xcode 9.3 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebello95
approved these changes
Mar 27, 2018
sberrevoets
approved these changes
Mar 27, 2018
sunshinejr
reviewed
Mar 27, 2018
| @@ -110,7 +110,7 @@ public struct Mapper { | |||
| } | |||
|
|
|||
| let rawValues = try array.map { try T.RawValue.fromMap($0) } | |||
| return rawValues.flatMap { T(rawValue: $0) ?? defaultValue } | |||
| return rawValues.compactMap { T(rawValue: $0) ?? defaultValue } | |||
There was a problem hiding this comment.
It won't build now for anyone that want to use this library with Swift 4.0.X, right?
There was a problem hiding this comment.
Yep, I'll wait for the final Xcode 9.3 release and once I merge this I will bump the major version.
There was a problem hiding this comment.
Yeah, I guess that's reasonable 👍
|
@keith Any chance this can be merged soon ?. Xcode 9.3 was released and this is failing on Carthage build. |
|
@Vkt0r 8.0.0 is tagged with this change. |
|
@keith 👍 Thanks for quick response. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.