This repository has been archived by the owner on May 17, 2024. It is now read-only.
Replace try? with custom try_ #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/remove-optional-try
branch
4 times, most recently
from
8b55b53
to
91b1b09
Compare
Currently in Swift 2.1, 2.2 and master of apple/swift, `try?` leaks memory. Until the bug is fixed and released we're replacing all instances of `try?` with a custom `try_` function that accomplishes the same thing.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Swift 2.1, 2.2 and master of apple/swift,
try?leaksmemory. Until the bug is fixed and released we're replacing all
instances of
try?with a customtry_function that accomplishes thesame thing.
Note, I've left
try?in the tests since we don't care about the leak there.