This repository has been archived by the owner on May 17, 2024. It is now read-only.
Add JSONSerialization integration tests #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
keith
force-pushed
the
ks/add-integration-tests
branch
from
1c19b5d
to
05da8e3
Compare
Turns out that dictionaries created via `NSJSONSerialization` act slightly differently than ones created literally through Swift. As far as we can tell this is caused by the bridging that happens between Objective-C and Swift. This adds some sanity checks for Double values specifically since NSNumbers act differently when passed through this filter.
keith
force-pushed
the
ks/add-integration-tests
branch
from
05da8e3
to
be88b24
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that dictionaries created via
NSJSONSerializationactslightly differently than ones created literally through Swift. As far
as we can tell this is caused by the bridging that happens between
Objective-C and Swift. This adds some sanity checks for Double values
specifically since NSNumbers act differently when passed through this
filter.