Uses new promise-based API to fix simulcast in Firefox (#1202)

lynckia · Apr 26, 2018 · 84faaa0 · 84faaa0
1 parent 5d58e0e
commit 84faaa0
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/erizo_controller/erizoClient/src/webrtc-stacks/FirefoxStack.js b/erizo_controller/erizoClient/src/webrtc-stacks/FirefoxStack.js
@@ -23,29 +23,34 @@ const FirefoxStack = (specInput) => {
     for (let layer = totalLayers - 1; layer >= totalLayers - numSpatialLayers; layer -= 1) {
       parameters.encodings.push(possibleLayers[layer]);
     }
-    sender.setParameters(parameters);
+    return sender.setParameters(parameters);
   };
 
   const enableSimulcast = () => {
     if (!that.simulcast) {
-      return;
+      return [];
     }
+    const promises = [];
     that.peerConnection.getSenders().forEach((sender) => {
       if (sender.track.kind === 'video') {
-        getSimulcastParameters(sender);
+        promises.push(getSimulcastParameters(sender));
       }
     });
+    return promises;
   };
 
   that.enableSimulcast = sdp => sdp;
 
   const baseCreateOffer = that.createOffer;
 
   that.createOffer = (isSubscribe, forceOfferToReceive = false, streamId = '') => {
+    let promises = [];
     if (isSubscribe !== true) {
-      enableSimulcast();
+      promises = enableSimulcast();
     }
-    baseCreateOffer(isSubscribe, forceOfferToReceive, streamId);
+    Promise.all(promises).then(() => {
+      baseCreateOffer(isSubscribe, forceOfferToReceive, streamId);
+    });
   };
 
   return that;