Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply maxVideoBW also to subscribers #1030

Merged

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Sep 15, 2017

Description

It enables the option to limit maxVideoBW in the subscriber side. It's really interesting for simulcast since two clients subscribed to the same publisher could have different max video bw without affecting the others.
A common use case happens when subscribers are connected from mobile phones and we don't want them to consume all their data traffic.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

We could only apply maxVideoBW to a publisher before this PR:

var config = {maxVideoBW: 300};
localstream.updateConfiguration(config, function(result) {
  console.log(result);
});

But now we can also set the maxVideoBW to remoteStreams:

var config = {maxVideoBW: 300};
remoteStream.updateConfiguration(config, function(result) {
  console.log(result);
});
  • It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcague jcague merged commit a6c6104 into lynckia:master Sep 15, 2017
@jcague jcague deleted the update/apply_max_video_bw_to_subscribers branch September 15, 2017 11:08
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants