Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Erizo SDP parser #1056

Merged
merged 4 commits into from
Oct 17, 2017
Merged

Fix Erizo SDP parser #1056

merged 4 commits into from
Oct 17, 2017

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Oct 17, 2017 •
edited
Loading

Description

There was an issue parsing the SDP issued by old versions of Chrome.

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

lodoyun
lodoyun approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@jcague
Copy link
Contributor Author

jcague commented Oct 17, 2017

I included here the fix in #1023

@jcague jcague merged commit 4c92ddb into lynckia:master Oct 17, 2017
@jcague jcague deleted the fix/erizo_sdp_parser branch October 17, 2017 10:41
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@jcague
Fix Erizo SDP parser (lynckia#1056)
7c7e2ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lodoyun lodoyun lodoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcague @lodoyun