Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed screen sharing when no video param is included in config #1069

Merged
merged 2 commits into from
Nov 27, 2017

Conversation

aalonsog
Copy link
Member

Description

This PR fixes screen sharing streams initialization when no video parameter is included.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aalonsog aalonsog merged commit 57bba5e into lynckia:master Nov 27, 2017
@aalonsog aalonsog deleted the minnor_fix_screen branch November 27, 2017 15:41
@Eyasserk
Copy link

Eyasserk commented Apr 9, 2018

Hi all,

I'm facing the same problem and I have the updated connection.js with the changes you did in your last commit but I still have the error "Cannot read property 'mandatory' of undefined"
Can you provide me with some further information?

Thanks in advance

Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants