Send SDP as JSON instead of String between clients and Erizo #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Nov 28, 2017
|
|
||
| md.connection = media.getConnection(); | ||
|
|
||
| md.xGoogleFlag = media.getXGoogleFlag('conference'); |
There was a problem hiding this comment.
getXGoogleFlag in MediaInfo does not take a parameter. If we need to check for the conference flag in particular, I'd implement that in this PR
| @@ -8,16 +8,14 @@ | |||
| 'target_name': 'addon', | |||
| 'sources': ['<@(common_sources)'], | |||
| 'include_dirs' : ['<@(common_include_dirs)'], | |||
| 'libraries': ['-L$(ERIZO_HOME)/build/release/erizo -lerizo -Wl,-rpath,./../../erizo/build/release/erizo'], | |||
| 'libraries': ['-L$(ERIZO_HOME)/build/release/erizo -lerizo -Wl,-rpath,<(module_root_dir)/../erizo/build/release/erizo'], | |||
This was referenced Nov 30, 2017
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send SDP as JSON instead of String between clients and Erizo.
This PR aims to start getting rid of SDP mangling using strings. We'll start using a JSON object representing the SDP, which makes the SDP updates much easier.
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.