Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari mobile support #1087

Merged
merged 4 commits into from
Dec 11, 2017
Merged

Safari mobile support #1087

merged 4 commits into from
Dec 11, 2017

Conversation

wolmi
Copy link
Contributor

@wolmi wolmi commented Dec 11, 2017

Description

The Safari support works on desktop but doesn't work on Safari Mobile.

For a first approach the "playsinline" parameter is needed on the videoplayer view of the erizo_Client.

More info in the issue opened on the adapter project:
https://github.com/webrtc/adapter/issues/685

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! good catch!

@jcague jcague merged commit a2d1a28 into lynckia:master Dec 11, 2017
@wolmi wolmi deleted the safari-mobile-support branch December 11, 2017 12:15
@wolmi wolmi restored the safari-mobile-support branch December 11, 2017 12:20
@wolmi wolmi deleted the safari-mobile-support branch December 11, 2017 12:21
@DmitriyKarpov
Copy link

Own video freezes on safari mobile when subscribing to remote streams, but other participants receives that video

@wolmi
Copy link
Contributor Author

wolmi commented Jan 19, 2018

Yes @DmitriyKarpov we are also experiencing this same situation.

Can you share your iOS mobile and Safari mobile version?

Are you having this issue on Safari descktop?

Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants