Update the media port in the SDP parser #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this might fix #1079 |
|
confirm it fixes #1079 |
lodoyun
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is something wrong in the current SDP parser that is affecting Simulcast and some feedback mechanisms. I've compared the SDPs generated by the previous solution and the current one and this is the only thing that is different, and that could be causing those issues. Not sure 100% if there is any other cause.
There was another issue caused by sending a=ssrc and a=ssrc-group in a different order compared with the previous SDPs. SdpInfo.cpp is not perfect and expected to receive a=ssrc-group first, which is not happening now. I added a temporal fix given that we'll eventually get rid of SdpInfo.cpp with the new parser.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.