Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Simulcast parser #1100

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Firefox Simulcast parser #1100

merged 2 commits into from
Dec 19, 2017

Conversation

kekkokk
Copy link
Contributor

@kekkokk kekkokk commented Dec 19, 2017

Implemented a proper parser for the old implementation of Simulcast (such the one in Firefox).
Simulcast on Firefox was working only thanks to a coincidence.

Fix simulcast not working on #1098

[] It needs and includes Unit Tests
[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks again for the contribution @kekkokk !

@@ -411,6 +413,12 @@ class SDPInfo {
}
}

if (simulcast03) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@jcague jcague merged commit 3a07e1f into lynckia:master Dec 19, 2017
@kekkokk kekkokk deleted the fix/firefox_sim_parser branch January 5, 2018 14:32
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants