Move offer creation logic out of Erizo #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Jan 9, 2018
| @@ -105,8 +105,8 @@ exports.ErizoJSController = function (threadPool, ioThreadPool) { | |||
|
|
|||
| case CONN_SDP: | |||
| case CONN_GATHERED: | |||
| mess = mess.replace(that.privateRegexp, that.publicIP); | |||
There was a problem hiding this comment.
The conversion to set the proper publicIp in the candidate is missing here
| return value; | ||
| } | ||
|
|
||
| function addSsrc(sources, ssrc, sdp, media) { |
There was a problem hiding this comment.
👍 A big improvement over the old implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It moves the logic to create SDP offer from Erizo to ErizoJS.
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.