Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate depacketizer in ExternalOuput adding h264 #1124

Merged
merged 2 commits into from
Jan 12, 2018

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Jan 12, 2018

Description
This PR integrates the new Depacketizer into ExternalOutput replacing all the old vp8 depacketizer login. As part of the process of integrating it, this PR updates the Depacketizer to better suit the rest of Erizo naming conventions and removing the throw code.
This PR also adds support for H264 in recording new that we have a compatible depacketizer, that required a minor change in LayerDetectorHandler to start marking the spatial layer of h264 packets (for now it's always 0).

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lodoyun lodoyun merged commit a255d03 into lynckia:master Jan 12, 2018
@nvazquezg
Copy link

@lodoyun This PR allows the creation of recordings using H264 codec? Or the output is still VP8 only?

@lodoyun
Copy link
Contributor Author

lodoyun commented Jan 26, 2018

@nvazquezg Yes, H.264 recording is supported for H.264 rooms, meaning Licode won't transcode when recording, it will record in the codec that the room is using.
Also, keep in mind the result is still a .mkv file so you will have to postprocess it to use any other format.

@nvazquezg
Copy link

@lodoyun Understood, thanks. To configure a room as H.264 I've set:
{ "mediaConfiguration": "H264_AND_OPUS" }.
Is there anything else I have to do? Because if I try to record in a room configured this way, I get the following error:

ERROR [0x7fdd31ffb700] media.ExternalOutput - Could not find video codec

I traced it to here:

ELOG_ERROR("Could not find video codec");

Please, tell me if I am doing something wrong or if I need to file an issue.

@yannistseng
Copy link
Contributor

yannistseng commented May 11, 2018

@nvazquezg try this

./scripts/installUbuntuDeps.sh --enable-gpl

@nvazquezg
Copy link

@yannistseng that did the trick. Thank you very much! 👍

@lodoyun lodoyun deleted the add/intregrateDepacketizer branch November 9, 2018 14:04
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants