Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new API to enable Single PC in ErizoClient #1165

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Mar 6, 2018

Description

A new option has been added to enable Single PC when publishing/subscribing to Erizo. It also forwards this flag to ErizoJS, which is also responsible for reusing existing Connections when it's enabled.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

It needs documentation, but I haven't added it yet since it's still experimental (it's actually broken right now) and we don't want people to start playing with it.

[] It includes documentation for these changes in /doc.

Copy link
Member

@aalonsog aalonsog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@jcague jcague merged commit c574ad3 into lynckia:master Mar 9, 2018
@jcague jcague deleted the add/api_to_enable_single_pc branch March 9, 2018 09:21
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants