-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/erizo client build errors #1171
Conversation
how do we invoke gulp watch now that gulp-cli is not global? |
@kekkokk Gulp is in |
just a note: I'd prefer to use $LICODE_ROOT/node_modules/.bin/gulp erizo instead of ../../node_modules/.bin/gulp erizo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Description
This fixes ErizoClient builds by specifying version numbers for all components involved and working around a couple of errors.
It also makes sure we notice when builds fail in CI by capturing gulp errors and terminating the process with an error code. That error code is also now properly propagated to the parent scripts if any (for instance
installErizo.sh
.[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc
.