Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/erizo client build errors #1171

Merged
merged 7 commits into from
Mar 21, 2018

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Mar 20, 2018

Description

This fixes ErizoClient builds by specifying version numbers for all components involved and working around a couple of errors.
It also makes sure we notice when builds fail in CI by capturing gulp errors and terminating the process with an error code. That error code is also now properly propagated to the parent scripts if any (for instance installErizo.sh.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@kekkokk
Copy link
Contributor

kekkokk commented Mar 20, 2018

how do we invoke gulp watch now that gulp-cli is not global?

@lodoyun
Copy link
Contributor Author

lodoyun commented Mar 20, 2018

@kekkokk Gulp is in licode/node_modules/.bin/gulp. I changed this in order to avoid confusions, we were installing gulp both in the global scope and in the scope of the package. I do prefer to install it in the package to avoid problems if your development machine, like mine, has more than one nvm.sh environment. I have one for licode and another one that is global.

@kekkokk
Copy link
Contributor

kekkokk commented Mar 20, 2018

just a note: I'd prefer to use $LICODE_ROOT/node_modules/.bin/gulp erizo instead of ../../node_modules/.bin/gulp erizo

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@lodoyun lodoyun merged commit b4bb832 into lynckia:master Mar 21, 2018
@lodoyun lodoyun deleted the fix/erizoClientBuildErrors branch September 20, 2018 07:34
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants